Skip to content

Commit

Permalink
tools: Upgrade Playwright
Browse files Browse the repository at this point in the history
Upgrade Playwright used in end-to-end png snapshot comparison tests from
1.48.2 to 1.49.1. Unfortunately local runs on Linux are still broken
and it seems almost all snapshots got updated again around fonts.

Commands run:

	npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
	npm --prefix e2e install
	npx --prefix e2e playwright install

Then a manual update to the docker image version in the playwright to:

	PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.46.0-jammy

And finally a snapshot update with

	make snaps USE_DOCKER=1
  • Loading branch information
juliaogris committed Dec 20, 2024
1 parent c035ab7 commit edb6d80
Show file tree
Hide file tree
Showing 22 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ define PLAYWRIGHT_CMD_LOCAL
npx --prefix e2e playwright test --config e2e $(PLAYWRIGHT_ARGS)
endef

PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.48.2-jammy
PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.49.1-jammy
PLAYWRIGHT_CMD_DOCKER = docker run --rm \
--volume $$(pwd):/work/ -w /work/ \
--user $(shell id -u):$(shell id -g) \
Expand Down
Binary file modified e2e/docs/test.js-snapshots/comment-hover-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/docs/test.js-snapshots/comment-page-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/docs/test.js-snapshots/expand-0-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/docs/test.js-snapshots/expand-1-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/docs/test.js-snapshots/printf-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/docs/test.js-snapshots/sidebar-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/docs/test.js-snapshots/start-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 13 additions & 13 deletions e2e/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions e2e/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": "true",
"devDependencies": {
"@playwright/test": "^1.48.2",
"playwright": "^1.48.2"
"@playwright/test": "^1.49.1",
"playwright": "^1.49.1"
}
}
Binary file modified e2e/play/test.js-snapshots/about-dialog-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/console-output-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/modal-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/no-dialog-chromium-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/no-dialog-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/no-sidebar-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/read-input-chromium-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/read-input-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/play/test.js-snapshots/sidebar-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/test.js-snapshots/landing-top-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/test.js-snapshots/playground-chromium-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/test.js-snapshots/playground-ios-docker.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit edb6d80

Please sign in to comment.