deploy: Simplify deployment process #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for ebd7285 |
Move `version.json` generation from `/out/public` to `/frontend`. This is a preparatory step to remove `/out/public` as an intermittent build step: we only ever want to serve `/frontend` directly without building or do a little extra to suit firebase deployment, such as subdomain link replacement and soon to come filename with hash replacements for better caching. Also move the `version.json` generation step from `frontend` to `tinygo` target. Now all frontend file generation happens in `tinygo` and we can remove the frontend step in a followup commit.
Rework frontend-serve target to serve frontend rather than out/public directory and shorten it to serve. There are no name clashes.
Remove separate `frontend` build step that copies forntend files to out/public.
Reorder functions for readability: `update_links` calls update `update_links_in_file` and now comes first. There is no functional change. This is more readable if you scan the file top to bottom. The reason it wasn't done in the first place was because I wasn't sure if I had to declare and export the function before I could use it. I wanted to get things to work first and then make them pretty, but forgot about making things pretty in the end - so let's do it now.
Move deployment preparation folder from /firebase/; /firebase/public -> /out/firebase; /out/firebase/public. Now /firebase only contains source files and almost all generated files and build output are in the out directory.
Simplify deploy target naming, drop `firebase-` prefix - we only ever deploy to firebase: firebase-deploy. -> deploy firebase-deploy-prod -> deploy-prod firebase-deploy-stage -> deploy stage Less typing, less confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify deployment process by copying files from
frontend/**toout/firebase/public/**once only. Copy all firebase configs to out/firebaseand run deployment from there. Clean up various little make things along the
way.
Fixes evylang/todo#47