frontend: Refactor confetti and Yace modules #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for 9573744 |
We are leaving the reference to the original YaceEditor in there but we have modified the original source a fair bit and the intention is for this file to become _the_ evy editor, so rename to `Editor`.
Move confetti easter egg to its own module - this is only a code moving commit, we will clean-up the code in a follow-up commit.
Make confetti.js self-contained by removing the dependency on a separate CSS file. This is done by embedding the CSS in the JS file as style object.
Refactor confetti module for readability and finding my JS style. The JS used in Evy is optimized for readability for Go developers so we'll take it easy on the functional idiom - arrow functions, filter/map/reduce, etc. There are also a couple of minor implementation fixes, such as improved side offset for confetti, confetti size depending on viewport height, rather than viewport with as we use in Evy. Options to configure confetti colors, print and count.
camh-
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename YaceEditor to Editor as it is increasingly becoming customized and
tailored to evy. Pull out confetti Easter egg into its own module and remove
dependency on separate CSS file. In last commit re-work confetti Easter egg
for readability.
Related evylang/todo#41