housekeeping: Upgrade tooling and deps #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade tools with hermit upgrade Upgrade node manually hermit install node-21.5.0 Again I'm not certain why hermit didn't do this, something todo with no explicit latest. I should get to the bottom of this. Upgrade golangci-lint config .golangci.yaml to not fail linting. Upgrade go.mod/go.sum to use latest versions of dependencies with go get -u go mod tidy
Pin prettier version by using a package.json file. Instead of polluting the root directory of this repo further, we have installed prettier with npm install --prefix .hermit/node --save-dev prettier Add .hermit/node/package.json and .hermit/node/package-lock.json for tool version tracking.
|
firebase-deployment for 7f8b316 |
camh-
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade tooling and go dependencies. I tried to write a make target for this,
but there seem to be too many manual steps involved - e.g. optionally
updating
go.modfile when go minor version changes, or manually installingmost recent firebase and node version.
After the upgrade is done, finally pin the prettier version by providing
package.jsonfile.