-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Initialize end to end testing #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firebase-deployment for dbbc43d |
camh-
reviewed
Jan 9, 2024
Initialize end to end testing in top level directory e2e. Everything related to end to end testing will be in this directory. Initialize node package with echo '{"private": true}' > e2e/package.json npm install --save-dev --prefix e2e playwright npm install --save-dev --prefix e2e @playwright/test@latest Add `node_modules/` to .gitignore. Setup basic playwright test config that will allow to parametrize the baseURL of tests. Add a minimal index.test.js test file that loads the Evy playground index.html page. It runs two tests on it: - ensure the title is "Evy | Playground" - execute `Run` and ensure the console output contains expected test. Issue: evylang/todo#43
camh-
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize end to end testing in top level directory e2e.
On CI e2 testing runs against https://evy.dev at the moment!
Initialize
e2e
node package withAdd
node_modules/
to .gitignore.Add a minimal
index.test.js
test file that loads the Evy playgroundindex.html
page. It runs two tests on it:
"Evy | Playground"
Run
and ensure the console output contains expected contents.Setup basic playwright test config that will allow to parametrize the
baseURL
for tests - it expects a
BASEURL
environment variable and falls back tohttps://localhost:8080
by default. For local development runand in other terminal
Add
e2e
target to make file, triggered byci
target.If
BASEURL
environment variable is not set, make will set it tohttps://evy.dev
for now. This allows us to prototype e2e testing until we can extract the per-PR
preview deployment URL from the firebase-deploy run.
We will add this in a follow up PR.
Despite concerns it seems that the CI runtime has increased by only less than 30 seconds at this stage.
Part 1/2 for evylang/todo#43