-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playsite: Add two more samples #453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e2f83f
to
d295b03
Compare
d295b03
to
e323d56
Compare
e323d56
to
f2e723a
Compare
f2e723a
to
17ac2ab
Compare
17ac2ab
to
ee33603
Compare
ee33603
to
ed35ad4
Compare
ed35ad4
to
947d495
Compare
947d495
to
ed59b62
Compare
ed59b62
to
1082294
Compare
1082294
to
a873c90
Compare
a873c90
to
2e8cdff
Compare
Fix link to game solution as the reference style link had duplicated text and linked to previous partial solution where it should have linked to the full solution in the end. Use more descriptive link text. This issue became apparent when revisiting the lab to extract the game for the playground.
Add two more samples, one for graphing mathematical functions one for a frogger style game as described in https://lab.evy.dev#game Keep them in a single commit to avoid updating snapshots twice.
2e8cdff
to
36243c2
Compare
camh-
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏 LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two more samples, one for graphing mathematical functions one for a
frogger style game as described in https://lab.evy.dev#game Keep them in a
single commit to avoid updating snapshots twice.
In preparatory commit fix link to game solution in labsite.
New samples:
https://evy-lang-stage-play--453-22k8veqn.web.app/#graph
https://evy-lang-stage-play--453-22k8veqn.web.app/#frogger
I'd much appreciate a careful eye on the Evy sources as they serve as samples.
Many thanks.
The lab-game solution and the playground game are slightly different as
func
has not yet been introduced in the lab at that point.WRT the hopefully fixed labsite, test on
https://evy-lang-stage-lab--453-86uuuode.web.app/#game
Click Next, Next, Next and try links under Hint buttons.