Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playsite: Add two more samples #453

Merged
merged 2 commits into from
Nov 20, 2024
Merged

playsite: Add two more samples #453

merged 2 commits into from
Nov 20, 2024

Conversation

juliaogris
Copy link
Member

@juliaogris juliaogris commented Nov 12, 2024

Add two more samples, one for graphing mathematical functions one for a
frogger style game as described in https://lab.evy.dev#game Keep them in a
single commit to avoid updating snapshots twice.

In preparatory commit fix link to game solution in labsite.


New samples:

https://evy-lang-stage-play--453-22k8veqn.web.app/#graph
https://evy-lang-stage-play--453-22k8veqn.web.app/#frogger

I'd much appreciate a careful eye on the Evy sources as they serve as samples.
Many thanks.

The lab-game solution and the playground game are slightly different as
func has not yet been introduced in the lab at that point.

WRT the hopefully fixed labsite, test on
https://evy-lang-stage-lab--453-86uuuode.web.app/#game
Click Next, Next, Next and try links under Hint buttons.

Fix link to game solution as the reference style link had duplicated
text and linked to previous partial solution where it should have
linked to the full solution in the end. Use more descriptive link
text.

This issue became apparent when revisiting the lab to extract the game
for the playground.
Add two more samples, one for graphing mathematical functions one for a
frogger style game as described in https://lab.evy.dev#game
Keep them in a single commit to avoid updating snapshots twice.
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 LGTM

@juliaogris juliaogris merged commit f9becbc into main Nov 20, 2024
4 checks passed
@juliaogris juliaogris deleted the play-samples branch November 20, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants