tools: Upgrade #459
Merged
tools: Upgrade #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade hermitised tools with hermit upgrade Manually check that there are no other major version upgrades of tools.
Upgrade node tooling with npx --prefix .hermit/node -y npm-check-updates --packageFile .hermit/node/package.json -u npm --prefix .hermit/node install npm --prefix .hermit/node audit fix Running the audit fix command was suggested by Node. Re-running the first two commands afterwards made no difference.
Upgrade Playwright used in end-to-end png snapshot comparison tests from 1.48.2 to 1.49.1. Unfortunately local runs on Linux are still broken and it seems almost all snapshots got updated again around fonts. Commands run: npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u npm --prefix e2e install npx --prefix e2e playwright install Then a manual update to the docker image version in the playwright to: PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.46.0-jammy And finally a snapshot update with make snaps USE_DOCKER=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade hermitised and node tools according to docs. It all went smoothly apart
from Playwright which required a bunch of snapshot updates again and is still
not working properly.
docs: https://github.com/evylang/evy/blob/5b196cbe154c60d68b2c2deffa41e118985ffba9/docs/development/upgrade.md