Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Upgrade #461

Merged
merged 4 commits into from
Feb 4, 2025
Merged

tools: Upgrade #461

merged 4 commits into from
Feb 4, 2025

Conversation

juliaogris
Copy link
Member

@juliaogris juliaogris commented Jan 30, 2025

Upgrade hermitised and node tools according to docs. It all went smoothly apart
from Playwright which required a bunch of snapshot updates again and is still
not working properly with local Node run on Linux :(.

docs: https://github.com/evylang/evy/blob/5b196cbe154c60d68b2c2deffa41e118985ffba9/docs/development/upgrade.md


Snapshot diffs seem to be mostly around font rendering again, but worth
taking a closer look with the GitHub image diff swipe feature.

Thank you!

Upgrade hermitised tools with

	hermit upgrade

Manually check that there are no other major version upgrades of tools.
Upgrade node tooling with

	npx --prefix .hermit/node -y npm-check-updates --packageFile .hermit/node/package.json -u
	npm --prefix .hermit/node install
Upgrade go dependencies with:

	go get -u ./...
	go mod tidy
	go get -C learn -u ./...
	go mod -C learn tidy
Upgrade Playwright used in end-to-end png snapshot comparison tests from
1.49.1-jammy to 1.50.0-noble. Unfortunately local runs on Linux are
still broken.

Commands run:

	npx --prefix e2e -y npm-check-updates --packageFile e2e/package.json -u
	npm --prefix e2e install
	npx --prefix e2e playwright install

Then a manual update to the docker image version in the playwright to:

	PLAYWRIGHT_OCI_IMAGE = mcr.microsoft.com/playwright:v1.50.0-noble

And finally a snapshot update with

	make snaps USE_DOCKER=1
Copy link
Member

@camh- camh- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥦

@juliaogris juliaogris merged commit a087a81 into main Feb 4, 2025
4 checks passed
@juliaogris juliaogris deleted the upgrade branch February 4, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants