Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 141 startup warnings in ebpf programs #145

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix 141 startup warnings in ebpf programs #145

merged 3 commits into from
Feb 2, 2023

Conversation

MatteoNardi
Copy link
Contributor

Fix #141:

  • Wait for the perf event map to be opened before starting to generate events
  • Shut down all modules before pulsar exits. This is also a partial fix for Handle clean shutdown of modules #7

I have

  • run cargo fmt;
  • run cargo clippy;
  • run cargo testand all tests pass;
  • linked to the originating issue (if applicable).

@MatteoNardi
fix(ebpf): wait init before sending events
641d1e6 
On eBPF program startup we had errors -2 when writing to the perf event
array. This happened because the userspace side of the map wasn't opened
yet.

Added a new map which contains the initialization status.
@MatteoNardi
fix(pulsar): stop modules before exiting
43a118f 
During shutdown, we got several errors in perf event output.
-28 ENOSPC: No space left on device
This happened because we were shutting down the userspace before the
eBPF program was unloaded.
@MatteoNardi MatteoNardi linked an issue Jan 31, 2023 that may be closed by this pull request
Startup warnings in eBPF programs #141
Closed
2 tasks
@MatteoNardi MatteoNardi merged commit 8105ff4 into main Feb 2, 2023
@MatteoNardi MatteoNardi deleted the 141-startup-warnings-in-ebpf-programs branch February 2, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banditopazzo banditopazzo banditopazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Startup warnings in eBPF programs
2 participants
@MatteoNardi @banditopazzo