Extract cgroup in bpf programs #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
requested changes
Jan 17, 2024
banditopazzo
force-pushed
the
improve-container-support
branch
from
c8a9fc9 to
7f296f9
Compare
Before this change, we were using `podman inspect` command to get information about libpod containers. But since Pulsar is running as root, using CLI is not going to show any information about rootless containers. This is fixed by using sqlite (which is used internally by libpod) and `images.json` file to resolve all necessary information about containers. To handle rootless containers gracefully, we check whether any user with their own home directory has a libpod database.
On such system, the following cgroup info was found: ``` 0::/machine.slice/libpod-conmon-551ccf517b3394[...].scope ``` Handle it in our regular expression.
banditopazzo
force-pushed
the
improve-container-support
branch
5 times, most recently
from
6bc2d74 to
cb6ab46
Compare
banditopazzo
force-pushed
the
improve-container-support
branch
from
cb6ab46 to
78a962f
Compare
vadorovsky
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wants to change the way cgroups are collected for processes at runtime.
The idea is to move cgroup extraction to BPF because
procfsis not reliable.remaining tasks
cgroups->subsys. panic: enum relocation index out of bounds aya-rs/aya#868nutIndex out of range Reeywhaar/nut#4vmlinux.hwithmemory_cgrp_idforx86_64chore: Update vmlinux headers to 6.7.2 #241is_new_containerfunctions and map