Merge Perl changes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSchierboom
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
LGTM! I've merged exercism/website-copy#2353
Before you can enable the analyzer, it also needs to be deployed to production. For that to happen, exercism/terraform#115 needs to be merged and terraform deployed. I can trigger the deploy once that is done.
Once that is done, I'll let you know and you can enable the analyzer in the track's config.json.
.github/workflows/ci.yml
Outdated
| context: . | ||
| push: false | ||
| load: true | ||
| tags: exercism/analyzer |
There was a problem hiding this comment.
Suggested change
| tags: exercism/analyzer | |
| tags: exercism/perl5-analyzer |
Could you do this for all exercism/analyzer occurences? We do this for GHA caching
|
@m-dango FYI we've enabled deployment of the analyzer, which means that whenever something is merged to main, it is auto deployed to production |
ErikSchierboom
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes files worked on from the generic analyzer.