-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary-search exercise (#297) #302
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Seems fine. The website bins difficulties 1 - 3 as "easy" so the specific level isn't too important. I try to avoid level 1 simply because exercises at the same level should be roughly equivalent in difficulty.
The naming is fine. Typically, I'd go with the property name from the canonical test json if it makes sense (so |
Ok, thanks! Well, I think it's ready then. I'll wait for your review and try to work on another in the meantime. 😉 |
Sorry, I didn't see your review on my phone. The formatting issues are resolved. Do not hesitate to tell me if there's anything else. |
Done. 😉 |
Oh, and could you please add the |
Related to #297
I put 2 as difficulty, what do you think?
Is the prototype and naming good (i.e.
binary-search array value
), or should it follow the instruction story (i.e.find-song-index playlist song
)?Do not hesitate to tell me there are things to modify @BNAndras. 😉