Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary-search exercise (#297) #302

Merged
merged 5 commits into from
Oct 29, 2023

Conversation

Adrien-LUDWIG
Copy link
Contributor

Related to #297

I put 2 as difficulty, what do you think?

Is the prototype and naming good (i.e. binary-search array value), or should it follow the instruction story (i.e. find-song-index playlist song)?

Do not hesitate to tell me there are things to modify @BNAndras. 😉

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 28, 2023
@BNAndras BNAndras reopened this Oct 28, 2023
@BNAndras
Copy link
Member

BNAndras commented Oct 28, 2023

I put 2 as difficulty, what do you think?>

Seems fine. The website bins difficulties 1 - 3 as "easy" so the specific level isn't too important. I try to avoid level 1 simply because exercises at the same level should be roughly equivalent in difficulty. hello-world is level 1 so only pretty straightforward exercises should also be level 1 in my opinion.

Is the prototype and naming good (i.e. binary-search array value), or should it follow the instruction story (i.e. find-song-index playlist song)?>

The naming is fine. Typically, I'd go with the property name from the canonical test json if it makes sense (so find array value). If the name can be tweaked to be more idiomatic, I'd do that like when transforming a to b, you'll often see a->b like number->string'. However binary-search` is fine, and other tracks take that approach as well.

@Adrien-LUDWIG
Copy link
Contributor Author

Ok, thanks!

Well, I think it's ready then. I'll wait for your review and try to work on another in the meantime. 😉

@Adrien-LUDWIG
Copy link
Contributor Author

Sorry, I didn't see your review on my phone. The formatting issues are resolved.

Do not hesitate to tell me if there's anything else.

@Adrien-LUDWIG
Copy link
Contributor Author

Done. 😉

@Adrien-LUDWIG
Copy link
Contributor Author

Oh, and could you please add the hacktoberfest-accepted label? 🙏😄

@BNAndras BNAndras merged commit 5687dd4 into exercism:main Oct 29, 2023
@Adrien-LUDWIG Adrien-LUDWIG deleted the add-binary-search branch October 30, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants