Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make anagram order-independent #411

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

BNAndras
Copy link
Member

Related to #410.

I'm sorting the student's results so they can return the anagrams in any order. This only matters when we have a list with more than one anagram so not all tests are touched. Racket's indent-all added some formatting noise, and I also reformatted the candidates for detects three anagrams since that line went a bit long on my screen

@BNAndras BNAndras added the x:rep/tiny Tiny amount of reputation label Jan 19, 2025
@BNAndras BNAndras requested a review from a team January 19, 2025 19:35
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@IsaacG
Copy link
Member

IsaacG commented Jan 19, 2025

Do you want to specify anything in an append about the order not mattering? If not, that's fine, too!

@BNAndras
Copy link
Member Author

Ah, we can just update the append in your PR and merge it in after this is merged.

Copy link
Contributor

@blakelewis blakelewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakelewis blakelewis merged commit 041452f into exercism:main Feb 14, 2025
7 checks passed
@BNAndras BNAndras deleted the make-anagram-order-independent branch February 18, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/tiny Tiny amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants