Skip to content

Commit

Permalink
Cleanup new_without_default workarounds
Browse files Browse the repository at this point in the history
  • Loading branch information
senekor committed Aug 9, 2024
1 parent 178476c commit 0d51c67
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion bin/ensure_stubs_compile.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ for dir in $changed_exercises; do
# since we're generally not going to test it.
if ! (
cd "$dir" &&
cargo clippy --lib --tests --color always -- --allow clippy::new_without_default 2>clippy.log
cargo clippy --lib --tests --color always -- 2>clippy.log
); then
cat "$dir/clippy.log"
broken="$broken\n$exercise"
Expand Down
7 changes: 0 additions & 7 deletions exercises/practice/grade-school/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
// This annotation prevents Clippy from warning us that `School` has a
// `fn new()` with no arguments, but doesn't implement the `Default` trait.
//
// Normally, it's good practice to just do what Clippy tells you, but in this
// case, we want to keep things relatively simple. The `Default` trait is not the point
// of this exercise.
#[allow(clippy::new_without_default)]
pub struct School {}

impl School {
Expand Down

0 comments on commit 0d51c67

Please sign in to comment.