Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync run-length-encoding with problem-specifications #1779

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Sync run-length-encoding with problem-specifications #1779

merged 2 commits into from
Nov 20, 2023

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Nov 17, 2023

[no important files changed]

@ErikSchierboom
Copy link
Member

Great. Before I approve the sync PRs, please keep in mind that if the test file has changed but its changes wouldn't result in any test result changes (e.g. because the test file changes are only cosmetic), please make sure to merge the PR with [no important files changed] in the commit body. An easy way to do this is by adding it to the description bit when doing a squash merge. See https://exercism.org/docs/building/tracks#h-avoiding-triggering-unnecessary-test-runs for more information.

@senekor
Copy link
Contributor Author

senekor commented Nov 20, 2023

Will do!

Would you consider changing the settings of this repository, so the PR description is automatically suggested as the message body of the squash commit? That way I can write it in the description and you will know I have already thought about it. And there is no risk of me then forgetting to actually put it in the commit message, like it happenend when I accidentally reran the tests for every single exercise...

image

@ErikSchierboom
Copy link
Member

Would you consider changing the settings of this repository, so the PR description is automatically suggested as the message body of the squash commit? That way I can write it in the description and you will know I have already thought about it. And there is no risk of me then forgetting to actually put it in the commit message, like it happenend when I accidentally reran the tests for every single exercise...

Good idea. Done!

@senekor senekor merged commit 70562b8 into main Nov 20, 2023
11 checks passed
@senekor senekor deleted the rle-sync branch November 20, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants