Add workflow to suggest skipping tests #1790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
force-pushed
the
no-important-files-changed
branch
13 times, most recently
from
1746a76 to
096d6f8
Compare
senekor
force-pushed
the
no-important-files-changed
branch
from
096d6f8 to
86fbe30
Compare
Comment on lines
18
to
23
| - name: Check if important files changed | ||
| id: check | ||
| env: | ||
| TARGET_BRANCH: ${{ github.base_ref }} | ||
| run: | | ||
| set -exo pipefail |
There was a problem hiding this comment.
Maybe we should check to see if the target branch is main instead? The reason for that is that only when something is merged to main will be actually be doing anything on the website side of things. That way this workflow wouldn't run when someone PR's something to a branch (which we don't care about from the website side of things).
Comment on lines
+7
to
+8
| permissions: | ||
| pull-requests: write |
There was a problem hiding this comment.
I like that you're being explicit about the permissions!
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea | ||
| with: | ||
| script: | | ||
| const body = "This PR touches files which probably affect the outcome of the tests of an exercise. If this is not the case, please add the following to the merge-commit message. Copy-paste to avoid typos. This will prevent tests from rerunning unnecessarily. For more information, refer to the [documentation](https://exercism.org/docs/building/tracks#h-avoiding-triggering-unnecessary-test-runs).\n```\n[no important files changed]\n```" |
There was a problem hiding this comment.
We probably want to tweak the wording a bit, but that's for later.
iHiD
reviewed
Jan 24, 2024
Co-authored-by: Jeremy Walker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.