Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use usize for counts in word-count #1874

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Use usize for counts in word-count #1874

merged 1 commit into from
Mar 27, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Mar 26, 2024

Due to type inference, this is not a breaking change. I tested with the old function signature using u32 as well, it still works.

closes #1845

[no important files changed]

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor senekor requested a review from ErikSchierboom March 26, 2024 21:20
@senekor senekor merged commit 80d9a18 into main Mar 27, 2024
12 checks passed
@senekor senekor deleted the word-count-usize branch March 27, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

word-count: change interface from u32 to usize
2 participants