Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protein-translation: sync #1895

Merged
merged 1 commit into from
Apr 9, 2024
Merged

protein-translation: sync #1895

merged 1 commit into from
Apr 9, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Apr 3, 2024

[no important files changed]

Copy link
Contributor

github-actions bot commented Apr 3, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor senekor force-pushed the protein-translation-sync branch from 29a4b6d to 962ce99 Compare April 3, 2024 12:18
@senekor
Copy link
Contributor Author

senekor commented Apr 3, 2024

blocked on this discussion

Edit: resolved in problem-specifications

@senekor
Copy link
Contributor Author

senekor commented Apr 3, 2024

I struggled with the separation of the name_for and of_rna methods, which is not intended by problem-specifications. I considered to map all tests with only one output amino acid to the name_for method, but that doesn't work because of some edge cases:

  • one amino acid and then immediately a stop codon (should test of_rna)
  • invalid codons returning None (should test name_for)

So the solution I came up with for now is to add all previous name_for tests as custom tests. This leads to duplicated tests (same input once for name_for and once for of_rna) but preserves the existing exercise design.

@senekor senekor force-pushed the protein-translation-sync branch from 962ce99 to 2e5a230 Compare April 7, 2024 13:03
@senekor senekor force-pushed the protein-translation-sync branch from 2e5a230 to e8ab6a8 Compare April 9, 2024 08:21
@senekor senekor requested a review from ErikSchierboom April 9, 2024 08:24
@senekor senekor merged commit bbae192 into main Apr 9, 2024
10 checks passed
@senekor senekor deleted the protein-translation-sync branch April 9, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants