Update instructions.append.md for Triangle #1933
Conversation
Fix inaccurate description of right triangles, tried to clarify the phrasing about irrational representation.
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Improve text's clarity and brevity by adopting Senekor's suggestion at [0]. [0] https://forum.exercism.org/t/pr-to-update-instructions-append-md-for-triangle/11752/3
The current version of
instructions.append.mdgives an inaccurate definition of a right triangle:an isosceles triangle whose equal sides are separated by 90 degrees(a right triangle need not be isosceles)
This PR attempts to fix this while trying not to add too much additional text that's incidental to the exercise - hopefully the result is readable!
The PR also tries to clarify a little the phrasing about the representation of irrationals, at the end of the same paragraph.