matrix: add tests for zero indexes #1944
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that it's very easy to accidentally write a solution to "Matrix" that panics when given an index of 0, since unchecked subtraction can panic in debug builds, and posted about it on the forum.
I realise that this change
maywill affect old solutions, and I'm happy to discuss further on the forum if needed, but I figured I'd prepare this simple PR anyway.