Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup new_without_default workarounds #1949

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Cleanup new_without_default workarounds #1949

merged 1 commit into from
Aug 9, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 9, 2024

No description provided.

@@ -61,7 +61,7 @@ for dir in $changed_exercises; do
# since we're generally not going to test it.
if ! (
cd "$dir" &&
cargo clippy --lib --tests --color always -- --allow clippy::new_without_default 2>clippy.log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked that exercise stubs don't produce clippy warnings as a preparation for running clippy in our analyzer. Removing this exception ensures that no new exercises with this problem are introduced. The best way to handle exercise-specific lint-exceptions is by specifying them in Cargo.toml.

@senekor senekor requested a review from ErikSchierboom August 9, 2024 13:17
@senekor senekor merged commit 8c408f0 into main Aug 9, 2024
12 checks passed
@senekor senekor deleted the remo/woxoyoxnvzvp branch August 9, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants