Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accumulate: sync #1954

Merged
merged 1 commit into from
Aug 13, 2024
Merged

accumulate: sync #1954

merged 1 commit into from
Aug 13, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 9, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor
Copy link
Contributor Author

senekor commented Aug 9, 2024

This is my first manual sync. The problem specification just doesn't lend itself to test generation. One would essentially have to parse and transpile the pseudo code in canonical-data...

I made sure that every test in .meta/tests.toml has a corresponding one in the rust test file and adjusted the names accordingly. I left the additional tests as they are, they are important to force the users to get the type signature right.

@senekor senekor requested a review from ErikSchierboom August 9, 2024 19:57
@senekor senekor merged commit e6a3c8e into main Aug 13, 2024
12 checks passed
@senekor senekor deleted the remo/upszxmzpsosk branch August 13, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants