Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto-square: sync #1973

Merged
merged 1 commit into from
Aug 15, 2024
Merged

crypto-square: sync #1973

merged 1 commit into from
Aug 15, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Aug 15, 2024

part of #1824

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@senekor
Copy link
Contributor Author

senekor commented Aug 15, 2024

Not adding [no important files changed] because the tests changed quite significantly, to the point where the example solution failed the new tests. I replaced it with my own.

@senekor senekor requested a review from ErikSchierboom August 15, 2024 08:50
@senekor senekor merged commit 3596893 into main Aug 15, 2024
12 checks passed
@senekor senekor deleted the remo/sxypuwtopxuv branch August 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants