Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching-brackets: Sync tests and add test template #2046

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

ellnix
Copy link
Contributor

@ellnix ellnix commented Mar 1, 2025

Some shenanigans was going on where tests were missing in tests.toml but were actually implemented in the test file. With this everything is consistent.

Specifically
fn early_incomplete_brackets() {}
fn early_mismatched_brackets() {}

Some shenanigans was going on where tests were missing in tests.toml but
were actually implemented in the test file. With this everything is
consistent.

Specifically
fn early_incomplete_brackets() {}
fn early_mismatched_brackets() {}
@ellnix ellnix requested a review from senekor March 1, 2025 20:58
Copy link
Contributor

github-actions bot commented Mar 1, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ellnix
Copy link
Contributor Author

ellnix commented Mar 1, 2025

I don't think any solutions that were working will now break, but as there is technically a new test I think the tests should run again.

@ellnix ellnix merged commit 66cfb28 into exercism:main Mar 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants