Skip to content

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Jul 30, 2025

I'm leaving this exercise as WIP status so we can double-check what this looks like with the 12 extra tabs (for the input files) in the online editor.

At the moment, I'm not having the students write to a local file, but we probably could (or should) since the instructions refer to them also doing that. I suppose we could have them write the formatted output to a second folder so inputs\01.txt goes into the Tally function and the expected output will be in outputs\01.txt.

https://forum.exercism.org/t/adding-change-exercise/17766 (a conversation of exercises being added to vimscript).

@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation labels Jul 30, 2025
@BNAndras BNAndras requested a review from a team July 30, 2025 06:08
@BNAndras
Copy link
Member Author

CI fails so I'll need to figure that part out.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed locally, looks good to me.

@kotp
Copy link
Member

kotp commented Aug 16, 2025

I'm leaving this as WIP status

The original message still has this, probably better to use the "draft" setting here, maybe, rather than something that remails "static".

So not quite sure what to do at the moment, other than ci failing still...

@kotp
Copy link
Member

kotp commented Aug 16, 2025

Probably needs a rebase on origin/main, as when I check this out, there
are way too many files that have changed. This may also be a source of
the ci/cd failure.

@BNAndras
Copy link
Member Author

Those are the test input files. I didn’t touch any other files outside of the usual stuff for adding an exercise

@BNAndras
Copy link
Member Author

I'm leaving this as WIP status

The original message still has this, probably better to use the "draft" setting here, maybe, rather than something that remails "static".

So not quite sure what to do at the moment, other than ci failing still...

"wip", "beta", "active", and "deprecated" are the valid statuses, and wip is appropriate for having the exercise initially available for only maintainers, not students.

@kotp
Copy link
Member

kotp commented Aug 16, 2025

"wip", "beta", "active", and "deprecated"

Sorry, had interpreted "this" as the status of this patch, not "this" as the exercise. All good, we are on the same page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants