-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add tournament
#347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tournament
#347
Conversation
CI fails so I'll need to figure that part out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed locally, looks good to me.
The original message still has this, probably better to use the "draft" setting here, maybe, rather than something that remails "static". So not quite sure what to do at the moment, other than ci failing still... |
Probably needs a rebase on origin/main, as when I check this out, there |
Those are the test input files. I didn’t touch any other files outside of the usual stuff for adding an exercise |
"wip", "beta", "active", and "deprecated" are the valid statuses, and wip is appropriate for having the exercise initially available for only maintainers, not students. |
Sorry, had interpreted "this" as the status of this patch, not "this" as the exercise. All good, we are on the same page. |
I'm leaving this exercise as
WIP
status so we can double-check what this looks like with the 12 extra tabs (for the input files) in the online editor.At the moment, I'm not having the students write to a local file, but we probably could (or should) since the instructions refer to them also doing that. I suppose we could have them write the formatted output to a second folder so
inputs\01.txt
goes into theTally
function and the expected output will be inoutputs\01.txt
.https://forum.exercism.org/t/adding-change-exercise/17766 (a conversation of exercises being added to vimscript).