Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for null compliant_custom_ops and null m.non_compliant_ops #82

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

masnesral
Copy link
Collaborator

Test Plan:

Before:

$ tlparse -o /tmp/foo --overwrite --no-browser --strict ~/tmp/trace_logs_slarsen/dedicated_log_torch_trace_l2k873uc.log
Detected rank: None
Parser compilation_metrics failed: Encountered rendering error on line 60, column 19. Reason: Expected an array for path 'm.compliant_custom_ops' but found a non-iterable value.
  [00:00:00] [#############################################################################################################################################################################################] 133.30 KiB/133.30 KiB [22.37 MiB/s] (0s)
  Stats { ok: 62, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 0, unknown: 0 }                                                                                                           Stats { ok: 63, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 1, unknown: 0 }
2024-12-04T19:57:19.454125Z ERROR cli_log: Something went wrong
2024-12-04T19:57:19.454280Z ERROR cli_log: An error was detected, uploading logs to LogView...
...

After:

$ /home/slarsen/local/tlparse/target/debug/tlparse -o /tmp/foo --overwrite --no-browser --strict ~/tmp/trace_logs_slarsen/dedicated_log_torch_trace_l2k873uc.log
Detected rank: None
  [00:00:00] [############################################################################################################################################################################################] 133.30 KiB/133.30 KiB [723.83 KiB/s] (0s)
  Stats { ok: 62, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 0, unknown: 0 }                                                                                                           Stats { ok: 63, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 0, unknown: 0 }

Test Plan:
```
$ tlparse -o /tmp/foo --overwrite --no-browser --strict ~/tmp/trace_logs_slarsen/dedicated_log_torch_trace_l2k873uc.log
Detected rank: None
Parser compilation_metrics failed: Encountered rendering error on line 60, column 19. Reason: Expected an array for path 'm.compliant_custom_ops' but found a non-iterable value.
  [00:00:00] [#############################################################################################################################################################################################] 133.30 KiB/133.30 KiB [22.37 MiB/s] (0s)
  Stats { ok: 62, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 0, unknown: 0 }                                                                                                           Stats { ok: 63, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 1, unknown: 0 }
2024-12-04T19:57:19.454125Z ERROR cli_log: Something went wrong
2024-12-04T19:57:19.454280Z ERROR cli_log: An error was detected, uploading logs to LogView...
...
```

```
$ /home/slarsen/local/tlparse/target/debug/tlparse -o /tmp/foo --overwrite --no-browser --strict ~/tmp/trace_logs_slarsen/dedicated_log_torch_trace_l2k873uc.log
Detected rank: None
  [00:00:00] [############################################################################################################################################################################################] 133.30 KiB/133.30 KiB [723.83 KiB/s] (0s)
  Stats { ok: 62, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 0, unknown: 0 }                                                                                                           Stats { ok: 63, other_rank: 0, fail_glog: 0, fail_json: 0, fail_payload_md5: 0, fail_dynamo_guards_json: 0, fail_parser: 0, unknown: 0 }
```
@ezyang ezyang merged commit d277ea1 into ezyang:main Dec 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants