[#62] feat : 선착순 쿠폰 발행 실패 -> 쿠폰 발행 배치 구현 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-thor
approved these changes
Aug 8, 2023
| private final EntityManagerFactory entityManagerFactory; | ||
| private final CouponBatchWriterRepository couponBatchWriterRepository; | ||
|
|
||
| private static final int chunkSize = 10; |
There was a problem hiding this comment.
말씀 드렸지만, chunkSize는 파라미터로 받도록 하는게 운영할 때 유연해서 유용합니다.
f-lab-thor
approved these changes
Aug 8, 2023
| String sql = "INSERT INTO coupon_issue (coupon_issue_token, member_id, coupon_id, used_yn, created_at, used_at) VALUES (UUID_TO_BIN(?), ?, ?, ?, ?, ?)"; | ||
|
|
||
| jdbcTemplate.batchUpdate(sql, | ||
| new BatchPreparedStatementSetter() { |
|
[생각해보기]
|
f-lab-thor
reviewed
Aug 8, 2023
| @Override | ||
| public void setValues(PreparedStatement ps, int i) throws SQLException { | ||
| CouponIssueFailedEntity entity = couponIssueFailedEntities.get(i); | ||
| ps.setObject(1, entity.getId()); |
There was a problem hiding this comment.
매직넘버 이네요.. 매직 넘버가 어떤 문제가 있을지 찾아보시면 좋을것 같습니다.
f-lab-thor
reviewed
Aug 8, 2023
| master: | ||
| jdbc-url: jdbc:mysql://118.67.135.217:32770/goodchoice | ||
| username: root | ||
| password: 1234 |
There was a problem hiding this comment.
실무에서는 이런 민감 정보는 key 관리 시스템에 위임 합니다.
f-lab-thor
reviewed
Aug 8, 2023
| } | ||
|
|
||
| @Test | ||
| void failedCouponJob() throws Exception { |
There was a problem hiding this comment.
저번처럼 해피케이스만 있네요? ㅎㅎ
말씀드렸지만 오히려 실패 했을때, 트랜잭션이 롤백되는지 확인하고
데이터 정합성 이슈가 없는지 동작 체킹하는게 더 중요합니다.
|
쿠폰 발행이 실패 된 케이스가 정상적으로 선착순이 안되서 실패 할 수도 있을텐데 그건 다시 배치로 발행하면 안되는거 잖아요? 정책으로 맞지 않을거 같은데 검토가 필요할것 같습니다. |
|
스프링 배치 메트릭 수집 및 그라파나 대쉬보드 구성해보고 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 요약
작업 내용
선착순 쿠폰 발행 실패 -> 쿠폰 발행 배치로 쿠폰 발행
read 는 쿼리 조회를 zero offset 으로 조회 했고, write는 배치 insert를 사용 했습니다.