Corrections: #1
Open
Corrections: #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an error in the 2D Gaussian kernel and something small in the total probability (it was not an error, but if we're looking for p(x), we shouldn't be using p(x) to calculate itself..) Also, edited a bit the representation of the 2D Gaussian kernel, that doesn't use the UNDERBRACE, but keeps it more linear. However, just above I have the commented the corrected version of the 2D Gaussian kernel, with the underbrace. If you prefer the version WITH, then comment out the second version and uncomment the first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-an error in the 2D Gaussian kernel and
-something small in the total probability (it was not an error, but if we're looking for p(x), we shouldn't be using p(x) to calculate itself..)
Also, edited a bit the representation of the 2D Gaussian kernel, that doesn't use the UNDERBRACE, but keeps it more linear.
However, just above I have the commented the corrected version of the 2D Gaussian kernel, with the underbrace.
If you prefer the version WITH, then comment out the second version and uncomment the first.