-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HMA] Removing IContentTypeConfigStore #1745
Conversation
Co-authored-by: Hai-Anh (Hennessy) Nguyen <[email protected]>
CI fails are expected here I believe.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, CI fails are not expected here, and will predict HMA library failures. We need a bumped version which contains the init fix.
This is the same problem that the MLH folks were running into, which you already found the solution to - the missing __init__.py
file.
To fix, you'll need to break this up a sequence of PRs:
1. Add __init__.py
to storage
2. Version bump
3. Now can remove.
EDIT: Now I'm confused, the storage interface is not in the right place. It's currently at https://github.com/facebook/ThreatExchange/tree/main/python-threatexchange/threatexchange/cli/storage but it should be in https://github.com/facebook/ThreatExchange/tree/main/python-threatexchange/threatexchange/storage
This looks like a mistake I made in review -_-
@@ -23,6 +23,7 @@ | |||
import flask | |||
from threatexchange.cli.storage.interfaces import ISignalTypeConfigStore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh, this should have been threatexchange.storage.interfaces
Hey! I'm around now; do you still want to take over? (Actually I just saw your edit, good catch I did not realize that lol) |
@b8zhong - didn't quite address! This PR is still needed, I just fixed the underlying stuff for you! |
hasher-matcher-actioner/src/OpenMediaMatch/storage/interface.py
Outdated
Show resolved
Hide resolved
There we go, mypy is finally happy |
Nice! |
Thanks for merging as always! |
Summary
Removes
IContentTypeConfigStore
, as requested in the last part of #1688.Note: I plan to add copyright boilerplate to the currently empty
init
+ bump minor version in a separate PR like you requested here! #1707Test Plan
N/A