Remove verbose "time-spent" prefix from "time-spent-synchronizing-and…

…-waiting"

Summary: This has been alive only for 2 days (on scuba) so I hope it is fine to change the name.

Reviewed By: IanChilds

Differential Revision: D68272464

fbshipit-source-id: 65d2e6d5411f2733d8f96d75a6ad68d48ec8fc2e

app/buck2_server_ctx/src/ctx.rs

@@ -40,7 +40,7 @@ use crate::concurrency::ConcurrencyHandler;
 use crate::concurrency::DiceUpdater;
 use crate::stderr_output_guard::StderrOutputGuard;
 
-const TIME_SPENT_SYNCHRONIZING_AND_WAITING: &str = "time-spent-synchronizing-and-waiting";
+const TIME_SPENT_SYNCHRONIZING_AND_WAITING: &str = "synchronizing-and-waiting";
 
 #[async_trait]
 pub trait ServerCommandContextTrait: Send + Sync {

tests/core/build/test_critical_path.py

@@ -43,7 +43,7 @@ async def do_critical_path(buck: Buck) -> None:
     ]
 
     expected = [
-        ("time-spent-synchronizing-and-waiting", ""),
+        ("synchronizing-and-waiting", ""),
         ("listing", "root//"),
         ("load", "root//"),
         ("analysis", "root//:step_0"),
@@ -91,7 +91,7 @@ async def test_critical_path_json(buck: Buck) -> None:
     critical_path = [json.loads(e) for e in critical_path]
 
     expected = [
-        ("time-spent-synchronizing-and-waiting", None),
+        ("synchronizing-and-waiting", None),
         ("listing", "root//"),
         ("load", "root//"),
         ("analysis", "root//:step_0"),
@@ -113,7 +113,7 @@ async def test_critical_path_json(buck: Buck) -> None:
 
         if (
             critical["kind"] == "compute-critical-path"
-            or critical["kind"] == "time-spent-synchronizing-and-waiting"
+            or critical["kind"] == "synchronizing-and-waiting"
         ):
             assert "name" not in critical
         else:
@@ -179,7 +179,7 @@ async def test_dynamic_input(buck: Buck) -> None:
 
         if (
             critical["kind"] == "compute-critical-path"
-            or critical["kind"] == "time-spent-synchronizing-and-waiting"
+            or critical["kind"] == "synchronizing-and-waiting"
         ):
             assert "name" not in critical
         else:

tests/core/build/test_critical_path_data/dynamic_input.golden.json

@@ -1,7 +1,7 @@
 # This file is @generated, regenerate by re-running test with `-- --env BUCK2_UPDATE_GOLDEN=1` appended to the test command
 
 [
-  "time-spent-synchronizing-and-waiting",
+  "synchronizing-and-waiting",
   "listing root//",
   "load root//",
   "analysis root//:step_0",