[flow][refactor] Remove unused type from Get_def_request.Identifier

Summary: Changelog: [internal]

Reviewed By: gkz

Differential Revision: D68004393

fbshipit-source-id: e648be29ca70621f28008d6db74178d47a7dfa7c

src/services/get_def/getDef_js.ml

@@ -42,7 +42,7 @@ let extract_member_def ~loc_of_aloc ~cx ~file_sig ~typed_ast_opt ~force_instance
 let rec process_request ~loc_of_aloc ~cx ~is_legit_require ~ast ~typed_ast_opt ~file_sig ~scope_info
     : (ALoc.t, ALoc.t * Type.t) Get_def_request.t -> (Loc.t Nel.t * string option, string) result =
   function
-  | Get_def_request.Identifier { name; loc = (aloc, _) } ->
+  | Get_def_request.Identifier { name; loc = aloc } ->
     let loc = loc_of_aloc aloc in
     let all_uses = Scope_api.With_Loc.all_uses scope_info in
     let matching_uses = Loc_collections.LocSet.filter (fun use -> Loc.contains use loc) all_uses in

src/services/get_def/get_def_process_location.ml

@@ -245,10 +245,7 @@ class virtual ['T] searcher _cx ~is_local_use ~is_legit_require ~covers_target ~
           ignore
           @@ this#request
                (Get_def_request.Identifier
-                  {
-                    name = local_name;
-                    loc = (this#loc_of_annot local_annot, this#type_from_enclosing_node local_annot);
-                  }
+                  { name = local_name; loc = this#loc_of_annot local_annot }
                );
       spec
 
@@ -383,8 +380,7 @@ class virtual ['T] searcher _cx ~is_local_use ~is_legit_require ~covers_target ~
 
     method! t_identifier ((loc, { Ast.Identifier.name; _ }) as id) =
       if this#annot_covers_target loc then begin
-        let t = this#type_from_enclosing_node loc in
-        this#request (Get_def_request.Identifier { name; loc = (this#loc_of_annot loc, t) })
+        this#request (Get_def_request.Identifier { name; loc = this#loc_of_annot loc })
       end;
       super#t_identifier id
 
@@ -413,8 +409,7 @@ class virtual ['T] searcher _cx ~is_local_use ~is_legit_require ~covers_target ~
     method! jsx_element_name_identifier ((annot, { Ast.JSX.Identifier.name; comments = _ }) as id) =
       if this#annot_covers_target annot then begin
         if name = String.capitalize_ascii name then
-          let annot = (this#loc_of_annot annot, this#type_from_enclosing_node annot) in
-          this#request (Get_def_request.Identifier { name; loc = annot })
+          this#request (Get_def_request.Identifier { name; loc = this#loc_of_annot annot })
         else
           this#found_empty "jsx intrinsic element"
       end;
@@ -429,8 +424,7 @@ class virtual ['T] searcher _cx ~is_local_use ~is_legit_require ~covers_target ~
     method! jsx_member_expression_identifier
         ((annot, { Ast.JSX.Identifier.name; comments = _ }) as id) =
       if this#annot_covers_target annot then begin
-        let annot = (this#loc_of_annot annot, this#type_from_enclosing_node annot) in
-        this#request (Get_def_request.Identifier { name; loc = annot })
+        this#request (Get_def_request.Identifier { name; loc = this#loc_of_annot annot })
       end;
       super#jsx_member_expression_identifier id
 

src/services/get_def/get_def_request.ml

@@ -15,7 +15,7 @@ type ('M, 'T) member_info = {
 type ('M, 'T) t =
   | Identifier of {
       name: string;
-      loc: 'T;
+      loc: 'M;
     }
   | Type of {
       annot: 'T;