repro issue with safe abstract logger

Summary:
In our logging for safe abstract, we weren't properly propagating information about the current method. This lead to the stats saying that some accesses `static::c` or `static::m()` were unsafe when they were actually safe

Repro the issue, fixed in next diff

Reviewed By: vassilmladenov

Differential Revision: D71195943

fbshipit-source-id: 627b7ae5ac0a18ffde9e92924f7013ae62192cea

Author: mheiber

hphp/hack/test/typecheck/safe_abstract/safe_abstract_logging_summarized/safe_abstract_logging_consts.php

@@ -1,8 +1,12 @@
 <?hh
 
+// safe_const_accesses":1,"unsafe_const_accesses":0
 abstract class C1 {
   abstract const int abs;
   const int concr = 1;
+  public function meth(): void {
+    static::abs;
+  }
 }
 
 final abstract class C2 extends C1 {

hphp/hack/test/typecheck/safe_abstract/safe_abstract_logging_summarized/safe_abstract_logging_consts.php.class_pointer.exp

@@ -1,5 +1,6 @@
 safe_abstract_logger:{"filename":"safe_abstract_logging_consts.php","safe_news":0,"unsafe_news":0,"safe_calls":0,"unsafe_calls":0,"safe_const_accesses":0,"unsafe_const_accesses":1}
-WARN: File "safe_abstract_logging_consts.php", line 14, characters 3-13:
+safe_abstract_logger:{"filename":"safe_abstract_logging_consts.php","safe_news":0,"unsafe_news":0,"safe_calls":0,"unsafe_calls":0,"safe_const_accesses":0,"unsafe_const_accesses":1}
+WARN: File "safe_abstract_logging_consts.php", line 18, characters 3-13:
 Unsafe class constant access: C1::abs might not exist because the receiver might be abstract. (Warn[12018])
-  File "safe_abstract_logging_consts.php", line 13, characters 27-28:
+  File "safe_abstract_logging_consts.php", line 17, characters 27-28:
   C1 is from 

hphp/hack/test/typecheck/safe_abstract/safe_abstract_logging_summarized/safe_abstract_logging_consts.php.exp

@@ -1,5 +1,6 @@
 safe_abstract_logger:{"filename":"safe_abstract_logging_consts.php","safe_news":0,"unsafe_news":0,"safe_calls":0,"unsafe_calls":0,"safe_const_accesses":0,"unsafe_const_accesses":1}
-WARN: File "safe_abstract_logging_consts.php", line 14, characters 3-13:
+safe_abstract_logger:{"filename":"safe_abstract_logging_consts.php","safe_news":0,"unsafe_news":0,"safe_calls":0,"unsafe_calls":0,"safe_const_accesses":0,"unsafe_const_accesses":1}
+WARN: File "safe_abstract_logging_consts.php", line 18, characters 3-13:
 Unsafe class constant access: C1::abs might not exist because the receiver might be abstract. (Warn[12018])
-  File "safe_abstract_logging_consts.php", line 13, characters 27-28:
+  File "safe_abstract_logging_consts.php", line 17, characters 27-28:
   C1 is from 

hphp/hack/test/typecheck/safe_abstract/safe_abstract_logging_verbose/safe_abstract_logging_consts.php

@@ -3,6 +3,9 @@
 abstract class C1 {
   abstract const int abs;
   const int concr = 1;
+  public function meth(): void {
+    static::abs; // use_kind: const_access, is_safe: true
+  }
 }
 
 final abstract class C2 extends C1 {

hphp/hack/test/typecheck/safe_abstract/safe_abstract_logging_verbose/safe_abstract_logging_consts.php.class_pointer.exp

@@ -1,6 +1,7 @@
-safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 13:2","use_kind":"const_access","is_safe":false}
-safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 14:2","use_kind":"const_access","is_safe":true}
-WARN: File "safe_abstract_logging_consts.php", line 13, characters 3-13:
+safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 16:2","use_kind":"const_access","is_safe":false}
+safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 17:2","use_kind":"const_access","is_safe":true}
+safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 7:4","use_kind":"const_access","is_safe":false}
+WARN: File "safe_abstract_logging_consts.php", line 16, characters 3-13:
 Unsafe class constant access: C1::abs might not exist because the receiver might be abstract. (Warn[12018])
-  File "safe_abstract_logging_consts.php", line 12, characters 24-25:
+  File "safe_abstract_logging_consts.php", line 15, characters 24-25:
   C1 is from 

hphp/hack/test/typecheck/safe_abstract/safe_abstract_logging_verbose/safe_abstract_logging_consts.php.exp

@@ -1,6 +1,7 @@
-safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 13:2","use_kind":"const_access","is_safe":false}
-safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 14:2","use_kind":"const_access","is_safe":true}
-WARN: File "safe_abstract_logging_consts.php", line 13, characters 3-13:
+safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 16:2","use_kind":"const_access","is_safe":false}
+safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 17:2","use_kind":"const_access","is_safe":true}
+safe_abstract_logger:{"pos":"(Relative_path.Dummy, \"safe_abstract_logging_consts.php\") 7:4","use_kind":"const_access","is_safe":false}
+WARN: File "safe_abstract_logging_consts.php", line 16, characters 3-13:
 Unsafe class constant access: C1::abs might not exist because the receiver might be abstract. (Warn[12018])
-  File "safe_abstract_logging_consts.php", line 12, characters 24-25:
+  File "safe_abstract_logging_consts.php", line 15, characters 24-25:
   C1 is from