Skip to content

Commit

Permalink
[gc] set compaction interval default to zero
Browse files Browse the repository at this point in the history
Summary:
It doesn't make sense to throttle compactions on the time axis when the objective is to avoid out-of-memory events.

This diff sets the default minimum time between manual compactions (because the heap size exceeds the threshold set) to zero.

Reviewed By: geralt-encore

Differential Revision:
D66630911

Privacy Context Container: L1208441

fbshipit-source-id: c936d2ad29b070ce132113489fb7a267429058e8
  • Loading branch information
ngorogiannis authored and facebook-github-bot committed Dec 2, 2024
1 parent 11457bc commit 641051e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions infer/man/man1/infer-full.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2652,8 +2652,7 @@ INTERNAL OPTIONS

--compaction-minimum-interval-s int
An analysis worker will only trigger compaction if this amount of
time (in seconds) has elapsed since last compaction. Defaults to
15
time (in seconds) has elapsed since last compaction. Defaults to 0

--compilation-database-escaped-reset
Set --compilation-database-escaped to the empty list.
Expand Down
4 changes: 2 additions & 2 deletions infer/src/base/Config.ml
Original file line number Diff line number Diff line change
Expand Up @@ -1305,9 +1305,9 @@ and compaction_if_heap_greater_equal_to_GB =


and compaction_minimum_interval_s =
CLOpt.mk_int ~long:"compaction-minimum-interval-s" ~default:15 ~meta:"int"
CLOpt.mk_int ~long:"compaction-minimum-interval-s" ~default:0 ~meta:"int"
"An analysis worker will only trigger compaction if this amount of time (in seconds) has \
elapsed since last compaction. Defaults to 15"
elapsed since last compaction. Defaults to 0"


and compilation_database =
Expand Down

0 comments on commit 641051e

Please sign in to comment.