Skip to content

Commit

Permalink
[infer] Remove logging of taint errors, it can be a lot
Browse files Browse the repository at this point in the history
Summary: This logging of taint errors before dedup can be very spammy, so let's remove it. The rest of the debug info should be sufficient to figure out what's going on.

Reviewed By: geralt-encore

Differential Revision: D49911304

fbshipit-source-id: 6a3e0d5a4d5c42cd6a8d9a1c1cd97b1a8d32d227
  • Loading branch information
dulmarod authored and facebook-github-bot committed Oct 4, 2023
1 parent 5963f63 commit 97373ab
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions infer/src/pulse/PulseTaintOperations.ml
Original file line number Diff line number Diff line change
Expand Up @@ -507,12 +507,10 @@ let dedup_reports results =
| Recoverable (a, errors) ->
let dedup_errors error (acc, taint_found) =
match error with
| ReportableError {diagnostic= TaintFlow {location; policy_id} as diagnostic} ->
| ReportableError {diagnostic= TaintFlow {location; policy_id}} ->
let found_duplicate =
LocationIntSet.exists (find_duplicate_taint location policy_id) taint_found
in
L.d_printfln_escaped ~color:Red "Taint error before deduplication %a" Diagnostic.pp
diagnostic ;
let taint_found = LocationIntSet.add (location, policy_id) taint_found in
if found_duplicate then (acc, taint_found) else (error :: acc, taint_found)
| _ ->
Expand Down

0 comments on commit 97373ab

Please sign in to comment.