Skip to content

Commit

Permalink
[multicore][summary] do not use biabduction models on multicore
Browse files Browse the repository at this point in the history
Summary: Biabduction will not be made thread-safe as it is being removed. This diff avoids a race on a lazy value inside the biabduction models code.

Reviewed By: jvillard

Differential Revision:
D67027861

Privacy Context Container: L1208441

fbshipit-source-id: 0edac9288d2609246aff1ab04be7104cc00b03d4
  • Loading branch information
ngorogiannis authored and facebook-github-bot committed Dec 11, 2024
1 parent 4539cfc commit d365f6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion infer/src/backend/Summary.ml
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ module OnDisk = struct
let load_summary_to_spec_table ~lazy_payloads analysis_req proc_name =
let summ_opt =
match spec_of_procname ~lazy_payloads proc_name with
| None when BiabductionModels.mem proc_name ->
| None when (not Config.multicore) && BiabductionModels.mem proc_name ->
(* most of the time we don't run biabduction and it's the only analysis with non-NULL
specs in these models, so load lazily *)
spec_of_model ~lazy_payloads:true proc_name
Expand Down

0 comments on commit d365f6d

Please sign in to comment.