Support more lenient error stack symbolication and don't fail for "empty url" and "address at" frames #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Notice, followup PR #187 adds tracking to these cases in 4494278)
Supporting stack traces with "empty URL" and "address at" URLs such as:
and
in the following stack trace:
This only allows having the following frames parsed as strings to unblock the symbolication of stack traces that contain them. However, the plans (T230100719) for them are:
(native)
frames- these might be enhanced to include the C++ loc for the frame so that a debugger could stitch together a hybrid cross-language call stack.address at
frames- these could be symbolicated and link to source files with the help of a bytecode source maps once they are available.more info:
https://docs.google.com/document/d/1Gq67flOcb37KbzmJ05G43TWAYxoxp391daAkmuEx8FQ/edit?usp=sharing
Test plan
The following stack trace gets symbolicated:

Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.