[compiler] Clean up deadcode: ReactiveFunctionValue

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook · Jan 16, 2025 · 0eab0fe · 0eab0fe
1 parent daaf493
commit 0eab0fe
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 55 deletions.
diff --git a/compiler/packages/babel-plugin-react-compiler/src/HIR/HIR.ts b/compiler/packages/babel-plugin-react-compiler/src/HIR/HIR.ts
@@ -108,16 +108,7 @@ export type ReactiveValue =
   | ReactiveLogicalValue
   | ReactiveSequenceValue
   | ReactiveTernaryValue
-  | ReactiveOptionalCallValue
-  | ReactiveFunctionValue;
-
-export type ReactiveFunctionValue = {
-  kind: 'ReactiveFunctionValue';
-  fn: ReactiveFunction;
-  dependencies: Array<Place>;
-  returnType: t.FlowType | t.TSType | null;
-  loc: SourceLocation;
-};
+  | ReactiveOptionalCallValue;
 
 export type ReactiveLogicalValue = {
   kind: 'LogicalExpression';

diff --git a/compiler/packages/babel-plugin-react-compiler/src/HIR/PrintHIR.ts b/compiler/packages/babel-plugin-react-compiler/src/HIR/PrintHIR.ts
@@ -701,10 +701,6 @@ export function printInstructionValue(instrValue: ReactiveValue): string {
       value = `FinishMemoize decl=${printPlace(instrValue.decl)}`;
       break;
     }
-    case 'ReactiveFunctionValue': {
-      value = `FunctionValue ${printReactiveFunction(instrValue.fn)}`;
-      break;
-    }
     default: {
       assertExhaustive(
         instrValue,

diff --git a/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts b/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts
@@ -2231,7 +2231,6 @@ function codegenInstructionValue(
       );
       break;
     }
-    case 'ReactiveFunctionValue':
     case 'StartMemoize':
     case 'FinishMemoize':
     case 'Debugger':

diff --git a/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/PruneNonEscapingScopes.ts b/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/PruneNonEscapingScopes.ts
@@ -772,14 +772,6 @@ function computeMemoizationInputs(
         rvalues: operands,
       };
     }
-    case 'ReactiveFunctionValue': {
-      CompilerError.invariant(false, {
-        reason: `Unexpected ReactiveFunctionValue node`,
-        description: null,
-        loc: value.loc,
-        suggestions: null,
-      });
-    }
     case 'UnsupportedNode': {
       CompilerError.invariant(false, {
         reason: `Unexpected unsupported node`,

diff --git a/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/visitors.ts b/compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/visitors.ts
@@ -73,15 +73,6 @@ export class ReactiveFunctionVisitor<TState = void> {
         this.visitValue(value.id, value.value, state);
         break;
       }
-      case 'ReactiveFunctionValue': {
-        this.visitReactiveFunctionValue(
-          id,
-          value.dependencies,
-          value.fn,
-          state,
-        );
-        break;
-      }
       default: {
         for (const place of eachInstructionValueOperand(value)) {
           this.visitPlace(id, place, state);
@@ -434,18 +425,6 @@ export class ReactiveFunctionTransform<
         }
         break;
       }
-      case 'ReactiveFunctionValue': {
-        const nextValue = this.transformReactiveFunctionValue(
-          id,
-          value.dependencies,
-          value.fn,
-          state,
-        );
-        if (nextValue.kind === 'replace') {
-          value.fn = nextValue.value;
-        }
-        break;
-      }
       default: {
         for (const place of eachInstructionValueOperand(value)) {
           this.visitPlace(id, place, state);
@@ -619,10 +598,6 @@ export function* eachReactiveValueOperand(
       yield* eachReactiveValueOperand(instrValue.alternate);
       break;
     }
-    case 'ReactiveFunctionValue': {
-      yield* instrValue.dependencies;
-      break;
-    }
     default: {
       yield* eachInstructionValueOperand(instrValue);
     }

diff --git a/...packages/babel-plugin-react-compiler/src/Validation/ValidatePreservedManualMemoization.ts b/...packages/babel-plugin-react-compiler/src/Validation/ValidatePreservedManualMemoization.ts
@@ -327,13 +327,6 @@ class Visitor extends ReactiveFunctionVisitor<VisitorState> {
       case 'OptionalExpression': {
         return this.recordDepsInValue(value.value, state);
       }
-      case 'ReactiveFunctionValue': {
-        CompilerError.throwTodo({
-          reason:
-            'Handle ReactiveFunctionValue in ValidatePreserveManualMemoization',
-          loc: value.loc,
-        });
-      }
       case 'ConditionalExpression': {
         this.recordDepsInValue(value.test, state);
         this.recordDepsInValue(value.consequent, state);