-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hc patchfrom part2 #4279
Hc patchfrom part2 #4279
Conversation
improves compression ratio at low levels
by avoiding to duplicate in memory a dictionary that was passed by reference.
thus saving a bit of memory and a little bit of cpu time
--patch-from no longer blocked on first job dictionary loading
notably when first job takes too long to load its prefix
c755adc
to
5bda54a
Compare
The new MT strategy in this PR favors keeping the jobs busy, As a consequence, this has an impact on the state of internal buffers at wake-up events, This leaves a few option:
The last 2 items obviously cost a lot more time than the first 2 ones, |
which is transferred to the current oldest unfinished job.
resulting in less "wasted" idle time
Changed for a combined strategy of waking up on flush event + waking up on job slot availability. |
This PR won't be merged. It's too complex and not stable enough. I'll see if some of the simpler ideas can provide benefits and create a separate PR with them if that's the case. |
just checking CI