Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #5428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Akash-Vijaysingh-Shekhavat
Copy link

@Akash-Vijaysingh-Shekhavat Akash-Vijaysingh-Shekhavat commented Jan 19, 2024

#5423 issue dataset link is updated

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

facebookresearch#5423 issue dataset link is updated
@facebook-github-bot
Copy link
Contributor

Hi @Akash-Vijaysingh-Shekhavat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Akash-Vijaysingh-Shekhavat
Copy link
Author

Update Dataset WMT 16 link

Copy link

@Pinak-Datta Pinak-Datta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Akash-Vijaysingh-Shekhavat , your PR is outdated in comparison with the Base Branch. I suggest you sync to the latest changes, and then make a PR, to avoid conflicts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants