This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
FabricJSIModuleProvider -> FabricUIManagerProviderImpl #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49259735 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Oct 16, 2023
Summary: X-link: facebookresearch/playtorch#231 1. Refactoring `FabricJSIModuleProvider` to implement the newly added `UIManagerProvider` interface instead of the `JSIModuleProvider` in order to get rid of JSI Module thereby renaming it to `FabricUIManagerProviderImpl` 2. Adding `setTurboModuleRegistry(TurboModuleRegistry turboModuleRegistry)`, `setFabricUIManager(UIManager fabricUIManager)`, `getFabricUIManager()` instead of `setTurboModuleManager(JSIModule getter)` 3. Replacing `mJSIModuleRegistry.notifyJSInstanceDestroy()` with `mTurboModuleRegistry.invalidate();` Changelog: [Internal] internal Differential Revision: D49259735
arushikesarwani94
added a commit
to arushikesarwani94/playtorch
that referenced
this pull request
Oct 16, 2023
Summary: X-link: facebook/react-native#39545 1. Refactoring `FabricJSIModuleProvider` to implement the newly added `UIManagerProvider` interface instead of the `JSIModuleProvider` in order to get rid of JSI Module thereby renaming it to `FabricUIManagerProviderImpl` 2. Adding `setTurboModuleRegistry(TurboModuleRegistry turboModuleRegistry)`, `setFabricUIManager(UIManager fabricUIManager)`, `getFabricUIManager()` instead of `setTurboModuleManager(JSIModule getter)` 3. Replacing `mJSIModuleRegistry.notifyJSInstanceDestroy()` with `mTurboModuleRegistry.invalidate();` Changelog: [Internal] internal Differential Revision: D49259735
arushikesarwani94
force-pushed
the
export-D49259735
branch
from
894ede4 to
b9c15e5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49259735 |
arushikesarwani94
added a commit
to arushikesarwani94/playtorch
that referenced
this pull request
Oct 16, 2023
Summary: X-link: facebook/react-native#39545 1. Refactoring `FabricJSIModuleProvider` to implement the newly added `UIManagerProvider` interface instead of the `JSIModuleProvider` in order to get rid of JSI Module thereby renaming it to `FabricUIManagerProviderImpl` 2. Adding `setTurboModuleRegistry(TurboModuleRegistry turboModuleRegistry)`, `setFabricUIManager(UIManager fabricUIManager)`, `getFabricUIManager()` instead of `setTurboModuleManager(JSIModule getter)` 3. Replacing `mJSIModuleRegistry.notifyJSInstanceDestroy()` with `mTurboModuleRegistry.invalidate();` Changelog: [Internal] internal Differential Revision: D49259735
arushikesarwani94
force-pushed
the
export-D49259735
branch
from
b9c15e5 to
28acc66
Compare
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Oct 16, 2023
Summary: X-link: facebookresearch/playtorch#231 1. Refactoring `FabricJSIModuleProvider` to implement the newly added `UIManagerProvider` interface instead of the `JSIModuleProvider` in order to get rid of JSI Module thereby renaming it to `FabricUIManagerProviderImpl` 2. Adding `setTurboModuleRegistry(TurboModuleRegistry turboModuleRegistry)`, `setFabricUIManager(UIManager fabricUIManager)`, `getFabricUIManager()` instead of `setTurboModuleManager(JSIModule getter)` 3. Replacing `mJSIModuleRegistry.notifyJSInstanceDestroy()` with `mTurboModuleRegistry.invalidate();` Changelog: [Internal] internal Differential Revision: D49259735
|
This pull request was exported from Phabricator. Differential Revision: D49259735 |
…rch#231) Summary: X-link: facebook/react-native#39545 1. Refactoring `FabricJSIModuleProvider` to implement the newly added `UIManagerProvider` interface instead of the `JSIModuleProvider` in order to get rid of JSI Module thereby renaming it to `FabricUIManagerProviderImpl` 2. Adding `setTurboModuleRegistry(TurboModuleRegistry turboModuleRegistry)`, `setFabricUIManager(UIManager fabricUIManager)`, `getFabricUIManager()` instead of `setTurboModuleManager(JSIModule getter)` 3. Replacing `mJSIModuleRegistry.notifyJSInstanceDestroy()` with `mTurboModuleRegistry.invalidate();` Changelog: [Internal] internal Differential Revision: D49259735
arushikesarwani94
force-pushed
the
export-D49259735
branch
from
28acc66 to
939cbf1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#39545
Refactoring
FabricJSIModuleProviderto implement the newly addedUIManagerProviderinterface instead of theJSIModuleProviderin order to get rid of JSI Module thereby renaming it toFabricUIManagerProviderImplChangelog:
[Internal] internal
Differential Revision: D49259735