This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
remove unused synthesized methodQueue ivars #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49440924 |
|
This pull request was exported from Phabricator. Differential Revision: D49440924 |
philIip
added a commit
to philIip/playtorch
that referenced
this pull request
Sep 20, 2023
Summary: X-link: facebook/react-native#39548 Pull Request resolved: facebookresearch#232 Changelog: [Internal] these aren't used, delete. i checked that no one else is trying to get the methodQueue of these modules as well. Differential Revision: D49440924 fbshipit-source-id: bbd329a066f36290ef13f773aeec22fe513bda15
philIip
force-pushed
the
export-D49440924
branch
from
07871c8 to
c7c3195
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 20, 2023
Summary: Pull Request resolved: facebook#39548 X-link: facebookresearch/playtorch#232 Changelog: [Internal] these aren't used, delete. i checked that no one else is trying to get the methodQueue of these modules as well. Differential Revision: D49440924 fbshipit-source-id: 76f6cfc5cecb312d6a300b5d034b387d5147065c
philIip
added a commit
to philIip/playtorch
that referenced
this pull request
Sep 20, 2023
Summary: X-link: facebook/react-native#39548 Changelog: [Internal] these aren't used, delete. i checked that no one else is trying to get the methodQueue of these modules as well. Reviewed By: christophpurrer Differential Revision: D49440924
philIip
force-pushed
the
export-D49440924
branch
from
c7c3195 to
2e2a4c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49440924 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 20, 2023
Summary: X-link: facebookresearch/playtorch#232 Changelog: [Internal] these aren't used, delete. i checked that no one else is trying to get the methodQueue of these modules as well. Reviewed By: christophpurrer Differential Revision: D49440924
Summary: X-link: facebook/react-native#39548 Changelog: [Internal] these aren't used, delete. i checked that no one else is trying to get the methodQueue of these modules as well. Reviewed By: christophpurrer Differential Revision: D49440924
philIip
force-pushed
the
export-D49440924
branch
from
2e2a4c5 to
c7519c7
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 21, 2023
Summary: X-link: facebookresearch/playtorch#232 Changelog: [Internal] these aren't used, delete. i checked that no one else is trying to get the methodQueue of these modules as well. Reviewed By: christophpurrer Differential Revision: D49440924
|
This pull request was exported from Phabricator. Differential Revision: D49440924 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
these aren't used, delete
Differential Revision: D49440924