Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CircleCI #1470

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated CircleCI #1470

wants to merge 2 commits into from

Conversation

johnnynunez
Copy link

@johnnynunez johnnynunez commented Mar 6, 2023

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2023
@facebook-github-bot
Copy link
Contributor

@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@bottler
Copy link
Contributor

bottler commented Mar 16, 2023

Thank you, this is very useful in drawing attention to potential improvements. There's a few things to think about. The changes to main are harmless as main is not being run. The binary_linux_conda_cuda is the main run which runs the tests right now. config.xml should be generated by regenerate.py (which needs updating if we want to delete builds). I think it is best separate dropping builds from CI improvements.

I'm not sure we are ready to add github actions, and not just for linting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants