Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fisheye Camera Typo and Overflow fix #1669

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jcjackch
Copy link

Typo fix

@facebook-github-bot
Copy link
Contributor

Hi @jcjackch!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2023
To prevent overflow in fisheye distortion
@facebook-github-bot
Copy link
Contributor

@jcjackch has updated the pull request. You must reimport the pull request before landing.

@bottler
Copy link
Contributor

bottler commented Oct 30, 2023

@jcjackch Do you want the epsilon stuff to be part of this PR? If so, might it be more efficient to use a boolean_mask like for th_divr? And also please update the PR title.

@jcjackch jcjackch changed the title Update fisheyecameras.py Fisheye Camera Typo and Overflow fix Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants