Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trimming option in ICP #1866

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ListIndexOutOfRange
Copy link
Contributor

The ICP algorithm is notably sensitive to outliers, as their corresponding distances s[i] X[i] R[i] + T[i] = Y[NN[i]] cost a lot. A simple strategy to alleviate this effect is to crop out points whose distance is above a threshold, computed as the r-th quantile of the point-to-point distances, where r in [0, 1] is the ratio of outliers.

This is usually called trimming, see e.g. D. Chetverikov et al., The Trimmed Iterative Closest Point Algorithm, 2002.

I propose to add the possibility to trim sources point clouds in the iterative_closest_point function, through a new parameter trim_fraction.

This is basically done by computing a mask for the distances, taking into account the already existing mask for padding.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants