Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ICP algorithm is notably sensitive to outliers, as their corresponding distances
s[i] X[i] R[i] + T[i] = Y[NN[i]]
cost a lot. A simple strategy to alleviate this effect is to crop out points whose distance is above a threshold, computed as the r-th quantile of the point-to-point distances, where r in [0, 1] is the ratio of outliers.This is usually called trimming, see e.g. D. Chetverikov et al., The Trimmed Iterative Closest Point Algorithm, 2002.
I propose to add the possibility to trim sources point clouds in the
iterative_closest_point
function, through a new parametertrim_fraction.
This is basically done by computing a mask for the distances, taking into account the already existing mask for padding.