feat(toolkit): set default expiration for cdn to never #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless we want it to be low by default, so that sdk users don't rely on it as persistent storage. fal_client doesn't support v3 yet, but that question is also relevant there. We could include lifecycle policy in the token we generate with rest though for every user and use that in every language client. That's probably a better long term solution. |
Discussing with @chamini2 , maybe we do want that. In that case the lower the default the better (so it breaks sooner). So maybe I should leave it as is and adopt the default from here in clients. |
|
Yup, will do that ^ . Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have per-request one working already, so no reason to limit really.