Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolkit): fallback to fal instead of cdn #420

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Feb 18, 2025

cdn just like fal_v3 are cloudflare-based, so if r2 or cf have an outage they will both go down. fal is our own legacy one that had the same feature parity as cdn (lacking object lifecycle, multipart) but still useful for now.

@efiop
Copy link
Contributor Author

efiop commented Feb 18, 2025

ah, missing test for that repo, WIP.

@efiop
Copy link
Contributor Author

efiop commented Feb 18, 2025

Correction, we do in test_stability.

@efiop efiop requested a review from chamini2 February 18, 2025 16:28
@chamini2
Copy link
Member

and how does this behave when v3 fails in multipart?

@efiop
Copy link
Contributor Author

efiop commented Feb 18, 2025

@chamini2 Like failing to upload a part? It will retry a few times within fal_v3 then error out, then will try fal which doesn't support multipart so it might fail if the file is too large. This is the same as with cdn.

@chamini2
Copy link
Member

@chamini2 Like failing to upload a part? It will retry a few times within fal_v3 then error out, then will try fal which doesn't support multipart so it might fail if the file is too large. This is the same as with cdn.

my question is, if it fails entirely on the multipart for v3, will it try to do multipart or single part to fal? can we make sure it makes the "right" decision of doing single part until multipart is handled correctly in fal

@efiop
Copy link
Contributor Author

efiop commented Feb 18, 2025

@chamini2 multipart is handled in particular implementation, fal doesn't support so it will never try multipart.

Again, this is exactly like with cdn that we've been using here.

@efiop efiop merged commit edeb221 into main Feb 18, 2025
10 checks passed
@efiop efiop deleted the ruslan/fal-fallback branch February 18, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants