Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print number of runners and requests on "app runners" #432

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

cmlad
Copy link
Contributor

@cmlad cmlad commented Feb 26, 2025

Screenshot 2025-02-26 at 11 02 00

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly would rather number them instead. I think that was requested before too.

@efiop
Copy link
Contributor

efiop commented Feb 26, 2025

Also requests are there temporarily, and this is really overloading the UI. Let me reconsider this, it is going to be harder to break this later.

@efiop
Copy link
Contributor

efiop commented Feb 26, 2025

Easy alternative is fal apps runners | wc -l

@cmlad
Copy link
Contributor Author

cmlad commented Feb 27, 2025

@efiop

Honestly would rather number them instead. I think that was requested before too.

What is the purpose of the numbers? Eventually be able to target runners by number, e.g. kill runner X?

Also requests are there temporarily, and this is really overloading the UI. Let me reconsider this, it is going to be harder to break this later.

We can move the counts when we break things up

Easy alternative is fal apps runners | wc -l
This is always inaccurate due to header, but also right now due to requests, it's quite difficult to make work

@cmlad cmlad merged commit f52020e into main Feb 27, 2025
10 checks passed
@cmlad cmlad deleted the chris/print-number-of-runners-requests branch February 27, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants