Hauke/swe 531 fix ci breakage #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollout of ubuntu-24.04 as ubuntu-latest broke our Python CI due to newer and stricter GCC. Mitigate by using ubuntu-20.04, matching what we currently use for the PyPI release.
Use supported runners that still support Python 3.8, matching the system Python on the Brain.
It doesn't appear to be used and conflicts with libc++-dev on ubuntu-22.04: https://bugs.launchpad.net/ubuntu/+source/google-glog/+bug/1991919
These rely on a prebuilt virtualenv for build tooling, created by the "Release" job, which would need additional attention.
This reverts commit 1986ebb.
The ADL-based friend lookup is helpful for operators but confusing and unnecessary for regular functions.
This reverts commit 7efcd0a.
strasdat
force-pushed
the
hauke/swe-531-fix-ci-breakage
branch
2 times, most recently
from
7a86e76 to
23a6688
Compare
strasdat
force-pushed
the
hauke/swe-531-fix-ci-breakage
branch
from
23a6688 to
b5a2a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.