Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Cosmos. #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tritao
Copy link

@tritao tritao commented Oct 16, 2021

As the title says, adds support for Cosmos-based networks.

Tested against the terra.js SDK.

@farukterzioglu
Copy link
Owner

Awesome, I will check as soon as possible.

@farukterzioglu
Copy link
Owner

Does Cosmos have any implementation other than Secp256k1? If not we can name it as just CosmosHDWallet not CosmosHDWalletSecp256k1. All of the wallets follow this naming, except Tezos which has both Secp256k1 and Ed25519 (not in this project though) implementation. Thats why it is called as TezosHDWalletSecp256k1

If cosmos doesn't have Ed25519 implemenration in use, you can name it to CosmosHDWallet

@tritao
Copy link
Author

tritao commented Oct 18, 2021

Does Cosmos have any implementation other than Secp256k1? If not we can name it as just CosmosHDWallet not CosmosHDWalletSecp256k1. All of the wallets follow this naming, except Tezos which has both Secp256k1 and Ed25519 (not in this project though) implementation. Thats why it is called as TezosHDWalletSecp256k1

If cosmos doesn't have Ed25519 implemenration in use, you can name it to CosmosHDWallet

Sounds good, I will update the PR with the rename.

@farukterzioglu
Copy link
Owner

@tritao Could you get the latest changes from master and do the mentioned changes above, so I can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants