Skip to content

Commit

Permalink
Add test files
Browse files Browse the repository at this point in the history
  • Loading branch information
kkweon committed Aug 14, 2019
1 parent 02c9650 commit 50e8a18
Show file tree
Hide file tree
Showing 5 changed files with 3,589 additions and 92 deletions.
4 changes: 4 additions & 0 deletions mocks/members.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
admin:
- A
members:
- B
7 changes: 7 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,15 @@
"typescript": "^3.5.3"
},
"devDependencies": {
"@types/jest": "^24.0.17",
"@types/js-yaml": "^3.12.1",
"@types/node": "^12.7.1",
"jest": "^24.8.0",
"ts-jest": "^24.0.2",
"ts-node": "^8.3.0"
},
"jest": {
"preset": "ts-jest",
"testEnvironment": "node"
}
}
31 changes: 31 additions & 0 deletions src/members-service.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { MembersService } from './members-service'

describe('MembersService', () => {
let s: MembersService

beforeEach(() => {
s = new MembersService('mocks/members.yaml')
})

test('load file', () => {
expect(s.hasMember('B')).toBeTruthy()
expect(s.hasAdmin('A')).toBeTruthy()
})

test('getMembersToAdd', () => {
// since current members are empty
// B should be added as a new member
const currentMembers: string[] = []
expect(s.getMembersToAdd(currentMembers)).toStrictEqual(['B'])

currentMembers.push('B')
expect(s.getMembersToAdd(currentMembers)).toStrictEqual([])
})

test('getMembersToDelete', () => {
// C does not exist in the file;
// so C must be removed
const currentMembers = ['B', 'C']
expect(s.getMembersToDelete(currentMembers)).toStrictEqual(['C'])
})
})
2 changes: 1 addition & 1 deletion src/members-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class MembersService {
this.data.admin.add(member)
}

hadAdmin(member: string): boolean {
hasAdmin(member: string): boolean {
return this.data.admin.has(member)
}

Expand Down
Loading

0 comments on commit 50e8a18

Please sign in to comment.